Bug 238148

Summary: Disable the <model> element in Captive Portal mode
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Brent Fulgham 2022-03-21 11:29:18 PDT 
When displaying content in a captive portal, we should make sure the experimental <model> element is unavailable.
Comment 1 Brent Fulgham 2022-03-21 11:29:31 PDT 
<rdar://90562002>
Comment 2 Brent Fulgham 2022-03-21 12:02:11 PDT 
Created attachment 455260 [details]
Patch
Comment 3 Chris Dumez 2022-03-21 12:48:43 PDT 
Comment on attachment 455260 [details]
Patch

r=me
Comment 4 Chris Dumez 2022-03-21 12:49:11 PDT 
Comment on attachment 455260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455260&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7825
> +    EXPECT_EQ(runJSCheck("!!window.HTMLModelElement"_s), shouldBeEnabled == ShouldBeEnabled::Yes); // Push API.

The comment is wrong.
Comment 5 Brent Fulgham 2022-03-21 13:04:23 PDT 
Comment on attachment 455260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455260&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7825
>> +    EXPECT_EQ(runJSCheck("!!window.HTMLModelElement"_s), shouldBeEnabled == ShouldBeEnabled::Yes); // Push API.
> 
> The comment is wrong.

Ugh! Thank you for catching that.
Comment 6 Brent Fulgham 2022-03-21 13:05:20 PDT 
Created attachment 455267 [details]
Patch for landing
Comment 7 EWS 2022-03-21 14:25:08 PDT 
Committed r291579 (248679@main): <https://commits.webkit.org/248679@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455267 [details].