Bug 238145

Summary: REGRESSION(r291055): Invalid test expectations
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, Morningstar, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237227    
Attachments:
Description Flags
REVERT of r291055 none

Description WebKit Commit Bot 2022-03-21 09:24:07 PDT 
https://commits.webkit.org/r291055 introduced a regression:
Invalid test expectations

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2022-03-21 09:24:11 PDT 
Created attachment 455252 [details]
REVERT of r291055

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 EWS 2022-03-21 16:37:31 PDT 
Committed r291587 (248682@main): <https://commits.webkit.org/248682@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455252 [details].
Comment 3 Radar WebKit Bug Importer 2022-03-21 16:38:22 PDT 
<rdar://problem/90600590>
Comment 4 Alexey Proskuryakov 2022-03-21 22:16:38 PDT 
r291055 both added TestExpectations and added Matteo to contributors.json (ugh).

So the revert reverted both changes.
Comment 5 Dawn Morningstar 2022-03-22 16:50:03 PDT 
(In reply to Alexey Proskuryakov from comment #4)
> r291055 both added TestExpectations and added Matteo to contributors.json
> (ugh).
> 
> So the revert reverted both changes.

My first commit. Lesson obviously learned.