| Summary: | [WebGPU] Set the WebGPU WKPreference to true in layout tests | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | sam, thorton, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Myles C. Maxfield
2022-03-20 16:55:11 PDT
Created attachment 455209 [details]
Patch
Comment on attachment 455209 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455209&action=review > Source/WebKit/ChangeLog:9 > + this patch adds a setter to WKPreferences, which is called by WebKitTestRunner. I should mention that this is SPI, not API. Created attachment 455215 [details]
Patch
Comment on attachment 455215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455215&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:1593 > +- (void)_setWebGPUEnabled:(BOOL)enabled This should not be necessary if the only place that wants to enable this is tests. > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:183 > +@property (nonatomic, setter=_setWebGPUEnabled:) BOOL _webgpuEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA)); This should not be necessary if the only place that wants to enable this is tests. > Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h:69 > +#define WebKitWebGPUEnabledPreferenceKey @"WebKitWebGPU" This should not be necessary if the only place that wants to enable this is tests. > Source/WebKitLegacy/mac/WebView/WebPreferences.mm:942 > +- (void)setWebgpuEnabled:(BOOL)webgpuEnabled This should not be necessary if the only place that wants to enable this is tests. > Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:259 > +@property (nonatomic) BOOL webgpuEnabled; This should not be necessary if the only place that wants to enable this is tests. > Tools/DumpRenderTree/mac/DumpRenderTree.mm:882 > + preferences.webgpuEnabled = YES; Instead of using new SPI, you can just add the key to DumpRenderTree/TestOptions.cpp > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:70 > + [copiedConfiguration preferences]._webgpuEnabled = YES; Instead of using new SPI, you can just add the key to WebKitTestRunner/TestOptions.cpp Created attachment 455270 [details]
Patch
Committed r291578 (248678@trunk): <https://commits.webkit.org/248678@trunk> |