| Summary: | Add an addition point for system background color | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | akeerthi, changseok, cpugh, dino, esprehn+autocc, ews-watchlist, glenn, hi, kondapallykalyan, pdr, webkit-bug-importer, wenson_hsieh | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tim Horton
2022-03-19 00:21:22 PDT
Created attachment 455166 [details]
Patch
Comment on attachment 455166 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455166&action=review > Source/WebCore/platform/ios/WebCoreUIColorExtras.mm:38 > + return (UIColor *)[PAL::getUIColorClass() blackColor]; The system background color is not always black or white. The trait collection's `userInterfaceLevel` and `accessibilityContrast` also affect this color. I don't think it would be a good idea to hardcode all the variations – I'll talk to you about possible alternate solutions. Created attachment 455175 [details]
Patch
Created attachment 455177 [details]
Patch
Committed r291564 (248666@main): <https://commits.webkit.org/248666@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455177 [details]. |