| Summary: | [IFC][Integration] Remove redundant InlineIterator::Line::contentLogicalTopAdjustedForHitTesting | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2022-03-18 21:20:20 PDT
Created attachment 455164 [details]
Patch
Comment on attachment 455164 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455164&action=review > Source/WebCore/ChangeLog:9 > + - containingBlock's borer and padding before border > Source/WebCore/layout/integration/InlineIteratorLineModernPath.h:-61 > - float contentLogicalTopAdjustedForHitTesting() const { return !m_lineIndex ? containingBlock().borderAndPaddingBefore().toFloat() : contentLogicalTopAdjustedForPrecedingLine(); }; Did you forget to remove the LineLegacyPath version? Created attachment 455188 [details]
Patch
Committed r291545 (248651@main): <https://commits.webkit.org/248651@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455188 [details]. |