Bug 238084

Summary:

[IFC][Integration] InlineIterator::Line::enclosingBottom should read enclosingBottomAdjustedForFollowingLine

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
[fast-cq]Patch	none
[fast-cq]Patch	none

Description zalan 2022-03-18 10:52:56 PDT

ssia

Comment 1 zalan 2022-03-18 10:53:53 PDT

Created attachment 455111 [details]
Patch

Comment 2 zalan 2022-03-18 11:10:41 PDT

Created attachment 455113 [details]
Patch

Comment 3 Antti Koivisto 2022-03-18 11:32:36 PDT

Comment on attachment 455113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455113&action=review

> Source/WebCore/layout/integration/InlineIteratorLine.h:99
> +    LayoutUnit enclosingBottomAdjustedForFollowingLine() const;
>      LayoutUnit enclosingTopAdjustedForPrecedingLine() const;

Top to the top!

Comment 4 zalan 2022-03-18 12:31:06 PDT

Created attachment 455126 [details]
[fast-cq]Patch

Comment 5 zalan 2022-03-19 11:19:15 PDT

Created attachment 455168 [details]
[fast-cq]Patch

Comment 6 EWS 2022-03-19 11:22:54 PDT

Committed r291529 (248635@main): <https://commits.webkit.org/248635@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455168 [details].

Comment 7 Radar WebKit Bug Importer 2022-03-19 11:23:19 PDT

<rdar://problem/90526693>