Bug 238077

Summary:	MacOS (ninja) and Latest Ubuntu 20.04 both builds fail with missing StackCheck::Scope::reportVerificationFailureAndCrash
Product:	WebKit	Reporter:	bigsean123
Component:	JavaScriptCore	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Major	CC:	mark.lam, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	All
OS:	Linux

Description bigsean123 2022-03-18 08:43:06 PDT

I've tried both builds for the purpose of fuzzing but the builds failed with the same linker failure...

For macOS I got this error 
Undefined symbols for architecture arm64:
  "WTF::StackCheck::Scope::reportVerificationFailureAndCrash()", referenced from:
WTF::StackCheck::Scope::Scope(WTF::StackCheck&) in libJavaScriptCore.a(UnifiedSource-bfc896e1-3.cpp.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
[884/894] Building CXX object Source/J...eFiles/testb3.dir/__/b3/testb3_1.cpp.o
ninja: build stopped: subcommand failed.

For Ubuntu I got this build error!
Consolidate compiler generated dependencies of target jsc
[100%] Linking CXX executable ../../../bin/jsc
/usr/bin/ld: ../../../lib/../Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir///JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-bfc896e1-3.cpp.o: in function WTF::StackCheck::Scope::Scope(WTF::StackCheck&)': UnifiedSource-bfc896e1-3.cpp:(.text._ZN3WTF10StackCheck5ScopeC2ERS0_[_ZN3WTF10StackCheck5ScopeC2ERS0_]+0x15c): undefined reference to WTF::StackCheck::Scope::reportVerificationFailureAndCrash()'
/usr/bin/ld: UnifiedSource-bfc896e1-3.cpp:(.text.ZN3WTF10StackCheck5ScopeC2ERS0[ZN3WTF10StackCheck5ScopeC2ERS0]+0x170): undefined reference to `WTF::StackCheck::Scope::reportVerificationFailureAndCrash()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[3]: *** [Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/build.make:103: bin/jsc] Error 1
gmake[2]: *** [CMakeFiles/Makefile2:762: Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:769: Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/rule] Error 2
gmake: *** [Makefile:362: jsc] Error 2

Comment 1 bigsean123 2022-03-18 17:53:34 PDT

here's the build commands 
export WEBKIT_OUTPUTDIR=FuzzBuild

if [ "$(uname)" == "Darwin" ]; then
    ./Tools/Scripts/build-jsc --jsc-only --debug --cmakeargs="-DENABLE_STATIC_JSC=ON -DCMAKE_CXX_FLAGS='-fsanitize-coverage=trace-pc-guard -O3'"
elif [ "$(uname)" == "Linux" ]; then
    ./Tools/Scripts/build-jsc --jsc-only --debug --cmakeargs="-DENABLE_STATIC_JSC=ON -DCMAKE_C_COMPILER='/usr/bin/clang-12' -DCMAKE_CXX_COMPILER='/usr/bin/clang++-12' -DCMAKE_CXX_FLAGS='-fsanitize-coverage=trace-pc-guard -O3 -lrt'"

Comment 2 Mark Lam 2022-03-18 20:02:53 PDT

This should already be fixed in http://trac.webkit.org/r291305.  Please re-test with the latest trunk.

Comment 3 bigsean123 2022-03-19 20:03:35 PDT

thanks that fixed it plus the latest pulled from GitHub also works.

Comment 4 Radar WebKit Bug Importer 2022-03-19 20:05:17 PDT

<rdar://problem/90531649>

Comment 5 bigsean123 2022-03-19 20:14:34 PDT

(In reply to Mark Lam from comment #2)
> This should already be fixed in http://trac.webkit.org/r291305.  Please
> re-test with the latest trunk.

Would this be a duplicate issue ? should I mark as such?

Comment 6 Mark Lam 2022-03-19 20:40:56 PDT

(In reply to bigsean123 from comment #5)
> (In reply to Mark Lam from comment #2)
> > This should already be fixed in http://trac.webkit.org/r291305.  Please
> > re-test with the latest trunk.
> 
> Would this be a duplicate issue ? should I mark as such?

I don't think the committer filed a separate bug for it.  I think RESOLVED - FIXED status is fine.