| Summary: | [GLIB] Make it possible to call GRefPtr::outPtr() multiple times wihtout an explicit clear | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, aperez, benjamin, bugs-noreply, calvaris, cdumez, cmarcelo, ews-watchlist, gyuyoung.kim, pnormand, ryuan.choi, sergio, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | Gtk, InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=236540 | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2022-03-18 04:51:46 PDT
Created attachment 455086 [details]
Patch
Comment on attachment 455086 [details]
Patch
LGTM, it may make sense to fix the style checker issue while at it.
Style failure doesn't matter here, because the file is not the implementation of any class, so there's no header tom include. I think there was a way to workaround it, but I'm not sure it's worth it for a unit test (In reply to Carlos Garcia Campos from comment #3) > Style failure doesn't matter here, because the file is not the > implementation of any class, so there's no header tom include. I think there > was a way to workaround it, but I'm not sure it's worth it for a unit test Maybe let's just not mind it, then :) Committed r291482 (248596@trunk): <https://commits.webkit.org/248596@trunk> |