Bug 238058

Summary:

libANGLE-shared.dylib, libwebrtc.dylib & WebGPU install names are prefixed with the system content path

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

Platform

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

david_quesada, dino, eric.carlson, ews-watchlist, kbr, kondapallykalyan, mark.lam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Updated Patch	mark.lam: review+

Description Michael Saboff 2022-03-17 16:51:47 PDT

The install names for these dylibs should not include the system content path prefix.

Comment 1 Michael Saboff 2022-03-17 16:51:59 PDT

<rdar://90449608>

Comment 2 Michael Saboff 2022-03-17 17:08:08 PDT

Created attachment 455048 [details]
Patch

Comment 3 EWS Watchlist 2022-03-17 17:10:26 PDT

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

Comment 4 David Quesada 2022-03-17 17:16:52 PDT

Comment on attachment 455048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455048&action=review

> Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:33
> +DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;

I don't think this is a correct default for iOS builds -- it should be `$(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks` since iOS doesn't use `Versions/A`

> Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:48
> +DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;

Ditto.

Comment 5 Michael Saboff 2022-03-17 17:22:41 PDT

(In reply to David Quesada from comment #4)
> Comment on attachment 455048 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455048&action=review
> 
> > Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:33
> > +DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;
> 
> I don't think this is a correct default for iOS builds -- it should be
> `$(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks` since iOS
> doesn't use `Versions/A`
> 
> > Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:48
> > +DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;
> 
> Ditto.

I'll update those and post a new patch.

Comment 6 Michael Saboff 2022-03-17 17:27:15 PDT

Created attachment 455052 [details]
Updated Patch

Comment 7 Mark Lam 2022-03-17 17:30:26 PDT

Comment on attachment 455052 [details]
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455052&action=review

r=me

> Source/ThirdParty/ANGLE/ChangeLog:3
> +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path

Can you fix non-ASCII chars here?

> Source/ThirdParty/libwebrtc/ChangeLog:3
> +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path

Ditto.

> Source/WebGPU/ChangeLog:3
> +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path

Ditto.

Comment 8 Michael Saboff 2022-03-17 17:34:15 PDT

(In reply to Mark Lam from comment #7)
> Comment on attachment 455052 [details]
> Updated Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455052&action=review
> 
> r=me
> 
> > Source/ThirdParty/ANGLE/ChangeLog:3
> > +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path
> 
> Can you fix non-ASCII chars here?
> 
> > Source/ThirdParty/libwebrtc/ChangeLog:3
> > +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path
> 
> Ditto.
> 
> > Source/WebGPU/ChangeLog:3
> > +        libANGLE-shared.dylib, Ælibwebrtc.dylib & WebGPU install names are prefixed with the system content path
> 
> Ditto.

Weird.  Must of got there when I copied from the radar.  These characters have been removed.

Comment 9 Michael Saboff 2022-03-17 17:46:21 PDT

Committed r291455 (248577@trunk): <https://commits.webkit.org/248577@trunk>