| Summary: | [GStreamer] Add stop position to the range request | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Enrique Ocaña <eocanha> | ||||||
| Component: | Media | Assignee: | Enrique Ocaña <eocanha> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | adam, pnormand, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Enrique Ocaña
2022-03-17 10:54:26 PDT
Created attachment 454997 [details]
Patch
Comment on attachment 454997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454997&action=review > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:680 > + formatedRange.reset(g_strdup_printf("bytes=%" G_GUINT64_FORMAT "-%" G_GUINT64_FORMAT, members->requestedPosition, (members->stopPosition > 0) ? members->stopPosition - 1 : 0)); The wrapping parentheses are not needed. Is this a regression of this: https://bugs.webkit.org/show_bug.cgi?id=236401 ? We have a customer that's having an issue playing videos within an embedded WebView in FileMaker Pro on macOS 12.3. While this bug appears to have been fixed in Safari proper, it looks like it's still broken in embedded WebViews. If this isn't related, let me know and I'll file a new bug. The GStreamer backend is not used by the mac ports, so I doubt this patch will solve your issues. Created attachment 455090 [details]
Patch
Found 2 new test failures: imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-cross-origin.sub.any.worker.html, imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-redirect-to-cross-origin.sub.any.worker.html Committed r291487 (248601@main): <https://commits.webkit.org/248601@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455090 [details]. |