Bug 238024

Summary: Recycling a webgl context when it has been lost and restored causes a crash
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, japhet, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=240821
Attachments:
Description Flags
wip
none
Patch
none
Patch for landing none

Description Kimmo Kinnunen 2022-03-17 07:40:02 PDT 
Recycling a webgl context when it has been lost and restored causes a crash

lose a context
schedule it for restore
force the context lost due to "recycling", e.g. exceeding active context limit
Comment 1 Kimmo Kinnunen 2022-03-17 07:43:36 PDT 
Created attachment 454973 [details]
wip
Comment 2 Kimmo Kinnunen 2022-03-17 12:06:05 PDT 
Created attachment 455000 [details]
Patch
Comment 3 Geoffrey Garen 2022-03-17 12:18:12 PDT 
Comment on attachment 455000 [details]
Patch

r=me

All red! I feel bad for taking away the ability to r+ this patch from Alex Christensen.
Comment 4 Kimmo Kinnunen 2022-03-18 00:50:37 PDT 
Created attachment 455074 [details]
Patch for landing
Comment 5 EWS 2022-03-18 05:19:10 PDT 
Committed r291477 (248593@main): <https://commits.webkit.org/248593@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455074 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-18 05:20:18 PDT 
<rdar://problem/90481699>