| Summary: | Add a public build option for PDF.js | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | Assignee: | Carlos Garcia Campos <cgarcia> | |||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | annulen, benjamin, bfulgham, bugs-noreply, cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, kangil.han, mcatanzaro, ntim, ryuan.choi, sergio, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=237513 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 235969 | ||||||
| Attachments: |
|
||||||
|
Description
Carlos Garcia Campos
2022-03-17 07:25:51 PDT
Created attachment 454971 [details]
Patch
- wihtout PDF.js: libwebkit2gtk-4.1.so.0.2.0 -> 91M - with PDF.js: libwebkit2gtk-4.1.so.0.2.0 -> 95M This is a developer release build in both cases. Comment on attachment 454971 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454971&action=review > Source/WebCore/page/SecurityOrigin.cpp:127 > #if PLATFORM(GTK) || PLATFORM(WPE) > || url.protocolIs("resource") > +#if ENABLE(PDFJS) > || url.protocolIs("webkit-pdfjs-viewer") > +#endif > #endif I know we discussed this in bug #237513, but thinking about it more, webkit-pdfjs-viewer should never be treated as a unique origin on any port. Just move it outside the #if PLATFORM(GTK) || PLATFORM(WPE). Comment on attachment 454971 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454971&action=review > ChangeLog:3 > + [GTK][WPE] Add a public build option for PDF.js This isn't really specific to GTK/WPE right? Comment on attachment 454971 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454971&action=review >> ChangeLog:3 >> + [GTK][WPE] Add a public build option for PDF.js > > This isn't really specific to GTK/WPE right? Well, the public build option is specific to GTK and WPE, for other ports it's an internal flag >> Source/WebCore/page/SecurityOrigin.cpp:127 >> #endif > > I know we discussed this in bug #237513, but thinking about it more, webkit-pdfjs-viewer should never be treated as a unique origin on any port. Just move it outside the #if PLATFORM(GTK) || PLATFORM(WPE). I prefer not to change the behavior in this patch, this is just about adding a build option. Committed r291473 (248589@trunk): <https://commits.webkit.org/248589@trunk> |