| Summary: | [WebGPU] Mark unchanging class members as const | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
| Component: | WebGPU | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, djg, kkinnunen, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Myles C. Maxfield
2022-03-16 21:05:12 PDT
Created attachment 454931 [details]
Patch
Comment on attachment 454931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454931&action=review > Source/WebGPU/WebGPU/Adapter.h:58 > + const id<MTLDevice> m_device { nil }; const members don't need initialisers, as the compiler checks that all the constructors initialise the member Comment on attachment 454931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454931&action=review >> Source/WebGPU/WebGPU/Adapter.h:58 >> + const id<MTLDevice> m_device { nil }; > > const members don't need initialisers, as the compiler checks that all the constructors initialise the member I'd like to keep them because of this: https://bugs.webkit.org/show_bug.cgi?id=237437#c2 Committed r291389 (248519@trunk): <https://commits.webkit.org/248519@trunk> |