| Summary: | compare-results should break down sync vs async time in Speedometer2 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||
| Component: | Tools / Tests | Assignee: | Saam Barati <saam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ap, ashvayka, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Saam Barati
2022-03-16 17:38:32 PDT
Created attachment 454920 [details]
patch
Comment on attachment 454920 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=454920&action=review > Tools/Scripts/compare-results:77 > + #print(json.dumps(breakdown._results, indent=4, sort_keys=True)) nit: remove debug comment? > Tools/Scripts/compare-results:86 > + if not syncTime: nit: flip condition? Comment on attachment 454920 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=454920&action=review >> Tools/Scripts/compare-results:77 >> + #print(json.dumps(breakdown._results, indent=4, sort_keys=True)) > > nit: remove debug comment? Yeah good point :-) >> Tools/Scripts/compare-results:86 >> + if not syncTime: > > nit: flip condition? I kinda like the ordering style wise now Created attachment 454993 [details]
[fast-cq] patch for landing
Alexey Shvaika found in /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Created attachment 455010 [details]
[fast-cq] patch for landing
Committed r291436 (248560@main): <https://commits.webkit.org/248560@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455010 [details]. Silly question, what is "sync" and "async" here? |