| Summary: | Calc() cleanup | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikos Mouchtaris <nmouchtaris> | ||||||||||||
| Component: | CSS | Assignee: | Nikos Mouchtaris <nmouchtaris> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Nikos Mouchtaris
2022-03-16 14:39:33 PDT
Created attachment 454896 [details]
Patch
Created attachment 455043 [details]
Patch
Created attachment 455047 [details]
Patch
Created attachment 455053 [details]
Patch
Comment on attachment 455053 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=455053&action=review > Source/WebCore/css/calc/CSSCalcOperationNode.cpp:76 > + default: The reason to not use `default` is that the compiler will warn you if you add a new enum value, but forget to add it to all the switch statements. > Source/WebCore/css/calc/CSSCalcOperationNode.cpp:146 > + default: Ditto. Created attachment 455125 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 455053 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=455053&action=review > > > Source/WebCore/css/calc/CSSCalcOperationNode.cpp:76 > > + default: > > The reason to not use `default` is that the compiler will warn you if you > add a new enum value, but forget to add it to all the switch statements. > > > Source/WebCore/css/calc/CSSCalcOperationNode.cpp:146 > > + default: > > Ditto. Yeah I didn't think that was necessary for these functions as they are only really used for the operators. Committed r291516 (248622@main): <https://commits.webkit.org/248622@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455125 [details]. |