| Summary: | [Cocoa] Minor AVVideoCaptureSource cleanup | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
| Component: | WebRTC | Assignee: | Eric Carlson <eric.carlson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, glenn, hta, jer.noble, peng.liu6, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=231621 | ||||||
| Attachments: |
|
||||||
|
Description
Eric Carlson
2022-03-16 13:13:26 PDT
Created attachment 454887 [details]
Patch
Comment on attachment 454887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454887&action=review > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:429 > + m_session = adoptNS([PAL::allocAVCaptureSessionInstance() init]); Looks like this change is not intended? Comment on attachment 454887 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454887&action=review >> Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:429 >> + m_session = adoptNS([PAL::allocAVCaptureSessionInstance() init]); > > Looks like this change is not intended? It is, it is needed to line up with the `else` above the `#else`. Committed r291374 (248506@main): <https://commits.webkit.org/248506@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454887 [details]. |