| Summary: | Fix for accessibility/aria-option-role.html in isolated tree mode. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||||
| Component: | Accessibility | Assignee: | Andres Gonzalez <andresg_22> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Andres Gonzalez
2022-03-16 12:41:19 PDT
Created attachment 454882 [details]
Patch
Comment on attachment 454882 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454882&action=review > LayoutTests/platform/mac/accessibility/aria-option-role-expected.txt:-8 > -firstChild.role is AXRole: AXStaticText we're no longer outputting the role value for these objects. I think we should make sure they're there Created attachment 454885 [details]
Patch
(In reply to chris fleizach from comment #3) > Comment on attachment 454882 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454882&action=review > > > LayoutTests/platform/mac/accessibility/aria-option-role-expected.txt:-8 > > -firstChild.role is AXRole: AXStaticText > > we're no longer outputting the role value for these objects. I think we > should make sure they're there Of course, missed the debug(output) after building the output string. Thanks for caching. Created attachment 454910 [details]
Patch
fix for glib and win expectations.
Committed r291400 (248530@main): <https://commits.webkit.org/248530@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454910 [details]. |