| Summary: | Pass style builder context to CSSToLengthConversionData | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||||
| Component: | CSS | Assignee: | Antti Koivisto <koivisto> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, jer.noble, kondapallykalyan, macpherson, menard, mifenton, pdr, philipj, sergio, webkit-bug-importer | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Antti Koivisto
2022-03-16 08:59:05 PDT
Created attachment 454846 [details]
Patch
Created attachment 454857 [details]
Patch
Created attachment 454862 [details]
Patch
Created attachment 454874 [details]
Patch
Created attachment 454876 [details]
Patch
Created attachment 454886 [details]
Patch
Comment on attachment 454886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454886&action=review > Source/WebCore/css/CSSToLengthConversionData.h:52 > + CSSToLengthConversionData(const RenderStyle&, const RenderStyle* rootStyle, const RenderStyle* parentStyle, const RenderView*); 'zoom' v. `zoom`, who should win? > Source/WebCore/css/MediaQueryEvaluator.cpp:949 > + return function(expression.value(), { *m_style, &defaultStyle, nullptr, document.renderView() }, *frame, NoPrefix); Should we ASSERT(m_style) here? > Should we ASSERT(m_style) here?
Nah, there is a null test pretty close above.
Committed r291398 (248528@main): <https://commits.webkit.org/248528@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454886 [details]. |