Bug 237952

Summary: WebGL context lost event is not sent again for contexts that are lost and restored
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, koivisto, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
For landing none

Description Kimmo Kinnunen 2022-03-16 03:42:32 PDT 
WebGL context lost event is not sent again for contexts that are lost and restored

The restored contexts do not set the GraphicsContextGL::Client
Comment 1 Kimmo Kinnunen 2022-03-16 05:09:47 PDT 
Created attachment 454823 [details]
Patch
Comment 2 Kimmo Kinnunen 2022-03-16 05:11:32 PDT 
Created attachment 454824 [details]
Patch
Comment 3 Kimmo Kinnunen 2022-03-16 05:35:05 PDT 
Created attachment 454828 [details]
For landing
Comment 4 Antti Koivisto 2022-03-16 05:35:36 PDT 
Comment on attachment 454824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454824&action=review

> Source/WebCore/platform/graphics/GraphicsContextGL.h:1050
> +    void setClient(Client* client) { m_client = client; }

This could assert that m_client is null.
Comment 5 Antti Koivisto 2022-03-16 05:36:28 PDT 
...or that either m_client or client is null.
Comment 6 EWS 2022-03-17 03:08:28 PDT 
Committed r291399 (248529@main): <https://commits.webkit.org/248529@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454828 [details].
Comment 7 Radar WebKit Bug Importer 2022-03-17 03:09:16 PDT 
<rdar://problem/90420387>