Bug 237944

Summary: [GPU Process] [GraphicsContextState 1/] Move other classes out of GraphicsContext.h
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237728    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
simon.fraser: review+
Patch none

Description Said Abou-Hallawa 2022-03-15 23:22:31 PDT 
This GraphicsContext class is big by itself. So let's have GraphicsContext.h be a header file for GraphicsContext only. The plan is to make GraphicsContextState a class and make it handle its encoding and decoding.
Comment 1 Said Abou-Hallawa 2022-03-16 01:33:10 PDT 
Created attachment 454809 [details]
Patch
Comment 2 Said Abou-Hallawa 2022-03-16 01:44:08 PDT 
Created attachment 454810 [details]
Patch
Comment 3 Said Abou-Hallawa 2022-03-16 10:37:55 PDT 
Created attachment 454859 [details]
Patch
Comment 4 Simon Fraser (smfr) 2022-03-16 11:13:36 PDT 
Comment on attachment 454859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454859&action=review

> Source/WebCore/platform/graphics/TextBoxIterator.h:36
> +        : m_textRun(0)
> +        , m_offset(0)

Use initializers and make this = default.
Comment 5 Said Abou-Hallawa 2022-03-16 11:46:35 PDT 
Created attachment 454871 [details]
Patch
Comment 6 EWS 2022-03-16 13:53:30 PDT 
Committed r291364 (248496@main): <https://commits.webkit.org/248496@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454871 [details].
Comment 7 Radar WebKit Bug Importer 2022-03-16 13:54:34 PDT 
<rdar://problem/90390439>