Bug 237944

Summary: [GPU Process] [GraphicsContextState 1/] Move other classes out of GraphicsContext.h
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237728    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
simon.fraser: review+
Patch none

Said Abou-Hallawa
Reported 2022-03-15 23:22:31 PDT
This GraphicsContext class is big by itself. So let's have GraphicsContext.h be a header file for GraphicsContext only. The plan is to make GraphicsContextState a class and make it handle its encoding and decoding.
Attachments
Patch (85.17 KB, patch)
2022-03-16 01:33 PDT, Said Abou-Hallawa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (85.30 KB, patch)
2022-03-16 01:44 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (85.66 KB, patch)
2022-03-16 10:37 PDT, Said Abou-Hallawa 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch (85.62 KB, patch)
2022-03-16 11:46 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2022-03-16 01:33:10 PDT
Created attachment 454809 [details] Patch
Said Abou-Hallawa
Comment 2 2022-03-16 01:44:08 PDT
Created attachment 454810 [details] Patch
Said Abou-Hallawa
Comment 3 2022-03-16 10:37:55 PDT
Created attachment 454859 [details] Patch
Simon Fraser (smfr)
Comment 4 2022-03-16 11:13:36 PDT
Comment on attachment 454859 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454859&action=review > Source/WebCore/platform/graphics/TextBoxIterator.h:36 > + : m_textRun(0) > + , m_offset(0) Use initializers and make this = default.
Said Abou-Hallawa
Comment 5 2022-03-16 11:46:35 PDT
Created attachment 454871 [details] Patch
EWS
Comment 6 2022-03-16 13:53:30 PDT
Committed r291364 (248496@main): <https://commits.webkit.org/248496@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454871 [details].
Radar WebKit Bug Importer
Comment 7 2022-03-16 13:54:34 PDT
<rdar://problem/90390439>
Note You need to log in before you can comment on or make changes to this bug.