| Summary: | Suspend newly created NetworkStorageManager if network process is or will be suspended | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||
| Component: | Website Storage | Assignee: | Sihui Liu <sihui_liu> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, sihui_liu, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sihui Liu
2022-03-15 12:49:23 PDT
Created attachment 454746 [details]
Patch
Created attachment 454748 [details]
Patch
Comment on attachment 454748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454748&action=review > Source/WebKit/NetworkProcess/NetworkProcess.cpp:2159 > + m_isSuspended = false; Please move this inside NetworkProcess::resume(). Alternatively, we could move the logic from resume() to here as I don't think it is needed anymore. I think we use to have the logic in resume() so we could call it from here and in suspension cancellation. However, I don't think suspension cancellation is a thing anymore. Created attachment 454795 [details]
Patch for landing
Committed r291334 (248473@main): <https://commits.webkit.org/248473@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454795 [details]. |