| Summary: | Make it clearer in the loading logging when it is for the main frame or not | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, esprehn+autocc, ews-watchlist, ggaren, japhet, kangil.han, kkinnunen, simon.fraser, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2022-03-15 12:20:41 PDT
Created attachment 454740 [details]
Patch
Comment on attachment 454740 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454740&action=review > Source/WebCore/page/FrameView.cpp:147 > +#define FRAMEVIEW_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", isFrameFrame=%d] FrameView::" fmt, this, PAGE_ID, FRAME_ID, frame().isMainFrame(), ##__VA_ARGS__) isFrameFrame (In reply to Alex Christensen from comment #2) > Comment on attachment 454740 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454740&action=review > > > Source/WebCore/page/FrameView.cpp:147 > > +#define FRAMEVIEW_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", isFrameFrame=%d] FrameView::" fmt, this, PAGE_ID, FRAME_ID, frame().isMainFrame(), ##__VA_ARGS__) > > isFrameFrame LOL, oops. thanks for catching. Created attachment 454754 [details]
Patch
Committed r291320 (248459@main): <https://commits.webkit.org/248459@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454754 [details]. |