Bug 237908

Summary: [fast-cq] REGRESSION(r291270): Changes need better build-time guards
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, dpino, jmason, lmoura, webkit-bug-importer, zan, zdobersek
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237897    
Attachments:
Description Flags
REVERT of r291294
none
Patch ews-feeder: commit-queue-

WebKit Commit Bot
Reported 2022-03-15 10:49:10 PDT
https://commits.webkit.org/r291294 introduced a regression: 291270 Changes need better build-time guards This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
REVERT of r291294 (1.76 KB, patch)
2022-03-15 10:49 PDT, WebKit Commit Bot 		no flags
DetailsFormatted DiffDiff
Patch (72.98 KB, patch)
2022-03-15 11:02 PDT, Zan Dobersek 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2022-03-15 10:49:16 PDT
Created attachment 454728 [details] REVERT of r291294 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Zan Dobersek
Comment 2 2022-03-15 11:02:58 PDT
Created attachment 454732 [details] Patch
Basuke Suzuki
Comment 3 2022-03-15 11:07:04 PDT
*** Bug 237904 has been marked as a duplicate of this bug. ***
Alejandro G. Castro
Comment 4 2022-03-15 11:41:24 PDT
*** Bug 237887 has been marked as a duplicate of this bug. ***
EWS
Comment 5 2022-03-15 13:10:44 PDT
Committed r291309 (248448@main): <https://commits.webkit.org/248448@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454732 [details].
Radar WebKit Bug Importer
Comment 6 2022-03-15 13:11:34 PDT
<rdar://problem/90326149>
Alejandro G. Castro
Comment 7 2022-03-16 02:00:38 PDT
*** Bug 237886 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.