Bug 237908

Summary: [fast-cq] REGRESSION(r291270): Changes need better build-time guards
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: Basuke.Suzuki, dpino, jmason, lmoura, webkit-bug-importer, zan, zdobersek
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237897    
Attachments:
Description Flags
REVERT of r291294
none
Patch ews-feeder: commit-queue-

Description WebKit Commit Bot 2022-03-15 10:49:10 PDT 
https://commits.webkit.org/r291294 introduced a regression:
291270 Changes need better build-time guards

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2022-03-15 10:49:16 PDT 
Created attachment 454728 [details]
REVERT of r291294

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Zan Dobersek 2022-03-15 11:02:58 PDT 
Created attachment 454732 [details]
Patch
Comment 3 Basuke Suzuki 2022-03-15 11:07:04 PDT 
*** Bug 237904 has been marked as a duplicate of this bug. ***
Comment 4 Alejandro G. Castro 2022-03-15 11:41:24 PDT 
*** Bug 237887 has been marked as a duplicate of this bug. ***
Comment 5 EWS 2022-03-15 13:10:44 PDT 
Committed r291309 (248448@main): <https://commits.webkit.org/248448@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454732 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-15 13:11:34 PDT 
<rdar://problem/90326149>
Comment 7 Alejandro G. Castro 2022-03-16 02:00:38 PDT 
*** Bug 237886 has been marked as a duplicate of this bug. ***