Bug 237881

Summary: AX: imported/w3c/web-platform-tests/speech-api/SpeechSynthesis (layout-tests) are constant text failures
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: andresg_22, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
ews-feeder: commit-queue-
patch none

chris fleizach
Reported 2022-03-15 01:02:00 PDT
imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-events.html is a constant text failure
Attachments
patch (6.52 KB, patch)
2022-03-15 01:07 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
patch (6.25 KB, patch)
2022-03-15 11:51 PDT, chris fleizach 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch (6.25 KB, patch)
2022-03-15 16:27 PDT, chris fleizach 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-15 01:02:12 PDT
<rdar://problem/90293806>
chris fleizach
Comment 2 2022-03-15 01:07:42 PDT
Created attachment 454678 [details] patch
Andres Gonzalez
Comment 3 2022-03-15 07:24:52 PDT
(In reply to chris fleizach from comment #2) > Created attachment 454678 [details] > patch --- a/Source/WebCore/ChangeLog +++ a/Source/WebCore/ChangeLog + This test failure was being a previous speech job was canceled, and a new one started. This sentence sounds weird to me, perhaps "was being" -> "was due to" or "was happening when". But I'm not English grammar expert :-). --- a/Source/WebCore/platform/PlatformSpeechSynthesisUtterance.h +++ a/Source/WebCore/platform/PlatformSpeechSynthesisUtterance.h + id platformSpeechUtteranceWrapper() const { return m_platformSpeechUtteranceWrapper.get(); } + void setPlatformSpeechUtteranceWrapper(id utterance) { m_platformSpeechUtteranceWrapper = utterance; } These names can be shortened to just wrapper() and setWrapper(...) like all other getters and setters in the class.
chris fleizach
Comment 4 2022-03-15 11:51:06 PDT
Created attachment 454737 [details] patch
chris fleizach
Comment 5 2022-03-15 16:27:05 PDT
Created attachment 454770 [details] patch
EWS
Comment 6 2022-03-16 06:15:27 PDT
Committed r291344 (248483@main): <https://commits.webkit.org/248483@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454770 [details].
Note You need to log in before you can comment on or make changes to this bug.