| Summary: | [WebGPU] Implement first draft of debug commands according to the spec | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||
| Component: | WebGPU | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dino, djg, kkinnunen, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 237877 | ||||||||||
| Bug Blocks: | 237882 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Myles C. Maxfield
2022-03-15 00:21:15 PDT
Created attachment 454673 [details]
Patch
Created attachment 454675 [details]
Patch
Comment on attachment 454675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454675&action=review > Source/WebGPU/WebGPU/RenderPassEncoder.mm:112 > + // There's no direct way of doing this, so we just push/pop an empty debug group. is this comment still valid? below we seem to insert a signpost instead of an empty debug group Comment on attachment 454675 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454675&action=review >> Source/WebGPU/WebGPU/RenderPassEncoder.mm:112 >> + // There's no direct way of doing this, so we just push/pop an empty debug group. > > is this comment still valid? below we seem to insert a signpost instead of an empty debug group Nope! Good catch. Created attachment 454929 [details]
Patch for committing
Committed r291386 (?): <https://commits.webkit.org/r291386> |