Bug 237869

Summary: [WebGPU] Implement queue submission methods according to the spec
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebGPUAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, djg, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 237864    
Bug Blocks: 237583, 237870    
Attachments:
Description Flags
Patch
none
Patch kkinnunen: review+

Description Myles C. Maxfield 2022-03-14 20:01:38 PDT 
.
Comment 1 Myles C. Maxfield 2022-03-14 20:13:22 PDT 
Created attachment 454655 [details]
Patch
Comment 2 Myles C. Maxfield 2022-03-14 20:14:41 PDT 
Created attachment 454656 [details]
Patch
Comment 3 Kimmo Kinnunen 2022-03-15 06:10:24 PDT 
Comment on attachment 454656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454656&action=review

> Source/WebGPU/WebGPU/Queue.h:73
> +    using OnSubmittedWorkDoneCallbacks = Vector<WTF::Function<void(WGPUQueueWorkDoneStatus)>>;

completion handler aspect comes back also here.
so later on, you perhaps should switch the onsubmitted api signature to use completion handler, as the. intention is to express "this function is valid only for one call".
Comment 4 Myles C. Maxfield 2022-03-16 14:20:11 PDT 
Committed r291366 (248498@trunk): <https://commits.webkit.org/248498@trunk>
Comment 5 Radar WebKit Bug Importer 2022-03-16 14:21:17 PDT 
<rdar://problem/90391949>
Comment 6 Myles C. Maxfield 2022-03-16 19:30:33 PDT 
Committed r291382 (248513@trunk): <https://commits.webkit.org/248513@trunk>