Bug 237868

Summary: Serialize grid-template correctly
Product: WebKit Reporter: Matt Woodrow <mattwoodrow>
Component: CSSAssignee: Matt Woodrow <mattwoodrow>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jfernandez, macpherson, menard, rego, svillar, webkit-bug-importer
Priority: P3 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 204611    
Attachments:
Description Flags
Patch
none
Patch
dino: review+, ews-feeder: commit-queue-
Patch for landing none

Matt Woodrow
Reported 2022-03-14 19:55:25 PDT
grid-template has an option to take an interleaved set of lines names, track sizes and area names, and we're supposed to serialise the result back in the same format rather than listing areas at the end.
Attachments
Patch (30.69 KB, patch)
2022-03-14 20:06 PDT, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Patch (32.78 KB, patch)
2022-03-15 13:38 PDT, Matt Woodrow 		dino: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (32.84 KB, patch)
2022-03-27 14:08 PDT, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-03-14 19:55:46 PDT
<rdar://problem/90284707>
Matt Woodrow
Comment 2 2022-03-14 20:06:47 PDT
Created attachment 454654 [details] Patch
Matt Woodrow
Comment 3 2022-03-15 13:38:22 PDT
Created attachment 454752 [details] Patch
Dean Jackson
Comment 4 2022-03-25 12:56:59 PDT
Comment on attachment 454752 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454752&action=review > Source/WebCore/css/StyleProperties.cpp:835 > + && downcast<CSSPrimitiveValue>(value.get())->valueID() == CSSValueNone; Nit: We indent this line > Source/WebCore/css/StyleProperties.cpp:837 > +} > +static bool isValueID(const Ref<CSSValue>& value, CSSValueID id) Nit: Need a blank line between these (and others)
Matt Woodrow
Comment 5 2022-03-27 14:08:28 PDT
Created attachment 455867 [details] Patch for landing
EWS
Comment 6 2022-03-27 20:04:47 PDT
Committed r291955 (248922@main): <https://commits.webkit.org/248922@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455867 [details].
Note You need to log in before you can comment on or make changes to this bug.