| Summary: | [WebAuthn] Mock UI interactions whenever virtual authenticators are in use. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | pascoe <pascoe> | ||||
| Component: | WebKit Misc. | Assignee: | pascoe <pascoe> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
pascoe@apple.com
2022-03-14 16:02:30 PDT
Created attachment 454652 [details]
Patch
Comment on attachment 454652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454652&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.h:-100 > - void decidePolicyForLocalAuthenticator(CompletionHandler<void(LocalAuthenticatorPolicy)>&&) final; It might be enough to just remove 'final' on these two methods, and not make them public. > Source/WebKit/UIProcess/WebAuthentication/Virtual/VirtualAuthenticatorManager.h:43 > + void runPanel(); void runPanel() override; This can also be 'private', since it is an override of the parent class method. Committed r291321 (248460@main): <https://commits.webkit.org/248460@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454652 [details]. |