Bug 237836
| Summary: | [JSC] Add a resolve_and_get_from_scope bytecode opcode | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Robin Morisset <rmorisset> |
| Component: | JavaScriptCore | Assignee: | Yijia Huang <yijia_huang> |
| Status: | NEW | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Robin Morisset
resolve_scope followed by get_from_scope is exceedingly common, it is visible both in manual checks of JS2, and was also found by Keith when he more rigorously looked at the most common pairs of opcodes (it was > 3% of all bytecode if I remember correctly).
Now that we've got checkpoints in bytecode ops it should be quite easy to add a shared opcode.
We've found in the past that optimizing bytecode size matters a lot, both to Ramification and to real-world websites.
As a bonus, this change should also reduce the interpretation overhead, making the LLint faster.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/90575798>
Yijia Huang
Pull request: https://github.com/WebKit/WebKit/pull/1579