| Summary: | [GStreamer] Avoid auto-selection of hole punching player | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Enrique Ocaña <eocanha> | ||||||||||
| Component: | Media | Assignee: | Enrique Ocaña <eocanha> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, jer.noble, magomez, philipj, sergio, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Enrique Ocaña
2022-03-14 06:46:40 PDT
Created attachment 454588 [details]
Patch
Created attachment 454589 [details]
Patch
Looks good to me Enrique! The editing/spelling/spellcheck-api-crash.html failure in the iOS-15-Simulator-WK2-Tests-EWS bot is unrelated to this patch and should be ignored. Actually, I've been seeing that failure in some other unrelated EWS patch submissions these days. Comment on attachment 454589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454589&action=review > Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp:191 > + if (mimeType.isEmpty() || !(mimeTypeCache().contains(mimeType))) !(mimeTypeCache().contains(mimeType)) -> !mimeTypeCache().contains(mimeType) Comment on attachment 454589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454589&action=review > Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp:189 > + if (m_player) { Return early. >> Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.cpp:191 >> + if (mimeType.isEmpty() || !(mimeTypeCache().contains(mimeType))) > > !(mimeTypeCache().contains(mimeType)) -> !mimeTypeCache().contains(mimeType) Extra parentheses after ! > Source/WebCore/platform/graphics/holepunch/MediaPlayerPrivateHolePunch.h:79 > - MediaPlayer::NetworkState networkState() const final { return MediaPlayer::NetworkState::Empty; }; > + MediaPlayer::NetworkState networkState() const final; We don't need to move this to the cpp, just return m_networkState here. Created attachment 454729 [details]
Patch
Created attachment 454741 [details]
Patch
Committed r291337 (248476@main): <https://commits.webkit.org/248476@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454741 [details]. |