| Summary: | [AT-SPI] accessibility/native-text-control-attributed-string.html is failing | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||||||||
| Component: | New Bugs | Assignee: | Lauro Moura <lmoura> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, cgarcia, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=237820 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Lauro Moura
2022-03-13 23:08:24 PDT
Created attachment 454564 [details]
Patch
Created attachment 454565 [details]
Patch with bugnumber
Comment on attachment 454565 [details] Patch with bugnumber View in context: https://bugs.webkit.org/attachment.cgi?id=454565&action=review > LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt:51 > +Attributed string for range (5, 10): In the mac expectation, this range has positions outside the string and ends up returning null. Should we do the same? > LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt:66 > +Attributed string for range (10, 1): Ditto. Comment on attachment 454565 [details] Patch with bugnumber View in context: https://bugs.webkit.org/attachment.cgi?id=454565&action=review >> LayoutTests/platform/gtk/accessibility/native-text-control-attributed-string-expected.txt:51 >> +Attributed string for range (5, 10): > > In the mac expectation, this range has positions outside the string and ends up returning null. Should we do the same? Yes, for consistency. I guess we just need to check the range is valid and return null otherwise. Created attachment 455721 [details]
Updated patch skipping out of range
The -1,1 out of range case still returns an attribute string as the location arrives as 0, like in the mac port
Comment on attachment 455721 [details] Updated patch skipping out of range View in context: https://bugs.webkit.org/attachment.cgi?id=455721&action=review > Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:1169 > + auto text = m_element->text(); You should also move m_element->updateBackingStore(); here, before calling text(). Created attachment 455949 [details]
Patch for landing
Committed r292019 (248963@main): <https://commits.webkit.org/248963@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455949 [details]. |