| Summary: | [JSC] Use addressTempRegister in loadValue(void *) on 32 bits | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> | ||||||
| Component: | New Bugs | Assignee: | Angelos Oikonomopoulos <angelos> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, glore, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki, zdobersek | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Angelos Oikonomopoulos
2022-03-11 05:11:18 PST
Created attachment 454471 [details]
Patch
Comment on attachment 454471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454471&action=review > Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:76 > + struct BoundsNonDoubleWordOffset { > + static bool within(intptr_t value) > + { > + return (value >= -0xff) && (value <= 0xfff); > + } > + }; > + struct BoundsDoubleWordOffset { > + static bool within(intptr_t value) > + { > + if (value < 0) > + value = -value; > + return !(value & ~0x3fc); > + } > + }; We could argue about these types' names, but let's not. Created attachment 454554 [details]
Patch
(In reply to Zan Dobersek (Reviews) from comment #2) [...] > We could argue about these types' names, but let's not. No argument from me. Committed r291217 (248372@main): <https://commits.webkit.org/248372@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454554 [details]. |