| Summary: | Fix WebContent jetsam that occurs when selecting text in a large e-mail | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Nham <nham> | ||||||
| Component: | Scrolling | Assignee: | Ben Nham <nham> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | nham, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | iPhone / iPad | ||||||||
| OS: | iOS 15 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ben Nham
2022-03-09 21:40:03 PST
Created attachment 454314 [details]
Patch
Comment on attachment 454314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454314&action=review > Source/WebCore/page/FrameView.cpp:2735 > +#if PLATFORM(IOS_FAMILY) > + tiledBacking->prepopulateRect(FloatRect(position, exposedContentRect().size())); > +#else > + auto rect = FloatRect(position, visibleContentRect().size()); > + if (auto exposedRect = viewExposedRect()) { > + exposedRect->setLocation(position); > + rect.intersect(*exposedRect); > + } > + tiledBacking->prepopulateRect(rect); > +#endif I generally prefer the #ifdef to just surround the argument computation, so there's only one line that calls tiledBacking->prepopulateRect(). Are you sure you want to change the macOS behavior at this time? It's probably better to leave the macOS path alone since content rects work differently on that platform and we don't have evidence of this bug on macOS. I'll submit a newer version of the patch. Created attachment 454315 [details]
Patch
Committed r291175 (248335@main): <https://commits.webkit.org/248335@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454315 [details]. |