| Summary: | [web-animations] font-variant-alternates should support discrete animation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | changseok, dino, esprehn+autocc, ews-watchlist, glenn, graouts, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar, WebExposed, WPTImpact | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2022-03-09 09:40:38 PST
Created attachment 454251 [details]
Patch
Comment on attachment 454251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454251&action=review > Source/WebCore/rendering/style/RenderStyle.h:376 > + FontVariantAlternates fontVariantAlternates() const { return fontDescription().variantAlternates(); } Do we need to fix RenderStyle::diff() for this? Comment on attachment 454251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454251&action=review >> Source/WebCore/rendering/style/RenderStyle.h:376 >> + FontVariantAlternates fontVariantAlternates() const { return fontDescription().variantAlternates(); } > > Do we need to fix RenderStyle::diff() for this? No. It's handled by FontDescription::operator==(). Committed r291104 (248266@trunk): <https://commits.webkit.org/248266@trunk> |