Bug 237657

Summary: [CSS Container Queries] Implement new container selection algorithm
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, macpherson, menard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=237715
Bug Depends on:    
Bug Blocks: 229659    
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Antti Koivisto
Reported 2022-03-09 07:54:40 PST
https://github.com/w3c/csswg-drafts/issues/6644
Attachments
Patch (23.70 KB, patch)
2022-03-09 08:35 PST, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2022-03-09 08:35:26 PST
Created attachment 454243 [details] Patch
Antoine Quint
Comment 2 2022-03-10 01:31:52 PST
Comment on attachment 454243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454243&action=review > Source/WebCore/css/ContainerQueryParser.cpp:41 > + auto consumeName = [&]() -> AtomString { I never know just by glancing at the code, but have you tried leaving out the explicit return type? > Source/WebCore/css/ContainerQueryParser.cpp:50 > + auto name = consumeName(); My personal preference is to call the lambda directly and not assign it an intermediate value.
Antti Koivisto
Comment 3 2022-03-10 01:38:14 PST
> I never know just by glancing at the code, but have you tried leaving out > the explicit return type? doesn't work here without other changes because stringValue() is not AtomicString
EWS
Comment 4 2022-03-10 02:23:30 PST
Committed r291098 (248260@main): <https://commits.webkit.org/248260@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454243 [details].
Radar WebKit Bug Importer
Comment 5 2022-03-10 02:24:16 PST
<rdar://problem/90087903>
Note You need to log in before you can comment on or make changes to this bug.