| Summary: | [CSS Container Queries] Implement new container selection algorithm | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | CSS | Assignee: | Antti Koivisto <koivisto> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, macpherson, menard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=237715 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 229659 | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2022-03-09 07:54:40 PST
Created attachment 454243 [details]
Patch
Comment on attachment 454243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454243&action=review > Source/WebCore/css/ContainerQueryParser.cpp:41 > + auto consumeName = [&]() -> AtomString { I never know just by glancing at the code, but have you tried leaving out the explicit return type? > Source/WebCore/css/ContainerQueryParser.cpp:50 > + auto name = consumeName(); My personal preference is to call the lambda directly and not assign it an intermediate value. > I never know just by glancing at the code, but have you tried leaving out
> the explicit return type?
doesn't work here without other changes because stringValue() is not AtomicString
Committed r291098 (248260@main): <https://commits.webkit.org/248260@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454243 [details]. |