| Summary: | [web-animations] increase the max number of animatable properties | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, graouts, koivisto, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2022-03-09 05:27:20 PST
Created attachment 454230 [details]
Patch
Comment on attachment 454230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454230&action=review > Source/WebCore/animation/CSSPropertyAnimation.cpp:2896 > + COMPILE_ASSERT(animatableLonghandPropertiesCount + animatableShorthandPropertiesCount < USHRT_MAX, numberOfAnimatablePropertiesMustBeLessThanUShrtMax); more modern C++ would say std::numeric_limits<unsigned short>::max() Committed r291047 (248221@trunk): <https://commits.webkit.org/248221@trunk> (In reply to Antti Koivisto from comment #2) > Comment on attachment 454230 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454230&action=review > > > Source/WebCore/animation/CSSPropertyAnimation.cpp:2896 > > + COMPILE_ASSERT(animatableLonghandPropertiesCount + animatableShorthandPropertiesCount < USHRT_MAX, numberOfAnimatablePropertiesMustBeLessThanUShrtMax); > > more modern C++ would say std::numeric_limits<unsigned short>::max() Used that in the commit. Thank you! |