Bug 237648

Summary:

[web-animations] fill-rule should support discrete animation

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Animations

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

changseok, dino, esprehn+autocc, ews-watchlist, glenn, graouts, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar, WebExposed, WPTImpact

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+

Description Antoine Quint 2022-03-09 04:08:43 PST

[web-animations] fill-rule should support discrete animation

Comment 1 Antoine Quint 2022-03-09 04:09:28 PST

Created attachment 454224 [details]
Patch

Comment 2 Simon Fraser (smfr) 2022-03-09 11:35:03 PST

Comment on attachment 454224 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454224&action=review

> Source/WebCore/rendering/style/RenderStyle.h:1429
> +    WindRule fillRule() const { return svgStyle().fillRule(); }
> +    void setFillRule(WindRule fillRule) { accessSVGStyle().setFillRule(fillRule); }

Does RenderStyle::diff() need to check this?

Comment 3 Antoine Quint 2022-03-10 03:38:59 PST

Committed r291100 (248262@trunk): <https://commits.webkit.org/248262@trunk>

Comment 4 Radar WebKit Bug Importer 2022-03-10 03:39:17 PST

<rdar://problem/90090179>