Bug 237634

Summary: Add myself (Gabriel Nava Marino) to contributors.json
Product: WebKit Reporter: Gabriel Nava Marino <gnavamarino>
Component: WebKit WebsiteAssignee: Gabriel Nava Marino <gnavamarino>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, jond, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing ews-feeder: commit-queue-

Description Gabriel Nava Marino 2022-03-08 19:20:10 PST
...
Comment 1 Gabriel Nava Marino 2022-03-08 19:31:59 PST
Created attachment 454187 [details]
Patch
Comment 2 EWS 2022-03-09 13:48:15 PST
gnavamarino@apple.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

Rejecting attachment 454187 [details] from commit queue.
Comment 3 Chris Dumez 2022-03-09 13:49:03 PST
Comment on attachment 454187 [details]
Patch

You need to commit the patch manually. You cannot use the commit queue to land a change stating that you are a committer.
Comment 4 Tim Nguyen (:ntim) 2022-03-14 16:32:13 PDT
Comment on attachment 454187 [details]
Patch

What Chris said. Use `webkit-patch land`.
Comment 5 Gabriel Nava Marino 2022-03-14 17:10:35 PDT
Created attachment 454638 [details]
Patch for landing
Comment 6 EWS 2022-03-14 17:10:42 PDT
gnavamarino@apple.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

Rejecting attachment 454638 [details] from commit queue.
Comment 7 Gabriel Nava Marino 2022-03-14 17:13:18 PDT
(In reply to Tim Nguyen (:ntim) from comment #4)
> Comment on attachment 454187 [details]
> Patch
> 
> What Chris said. Use `webkit-patch land`.

I was having some issues with svn, but I think I've resolved them. I will be doing this now.
Comment 8 Gabriel Nava Marino 2022-03-14 17:18:03 PDT
Committed r291256 (248408@trunk): <https://commits.webkit.org/248408@trunk>
Comment 9 Radar WebKit Bug Importer 2022-03-14 17:19:18 PDT
<rdar://problem/90278866>