| Summary: | [Cocoa] metadata cue endTime may not be updated | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
| Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ashukm4, calvaris, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, peng.liu6, philipj, sergio, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Eric Carlson
2022-03-08 17:04:50 PST
Created attachment 454179 [details]
Patch
Comment on attachment 454179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454179&action=review > Source/WebCore/ChangeLog:10 > + the next data cue from the same track starts. This means we donât know the Nit. "don't". > Source/WebCore/ChangeLog:12 > + given the end time of the media fileâs duration and the actual end time is updated Nit. "media file's"? > Source/WebCore/ChangeLog:22 > + This means that if the media fileâs duration is not known when the text track list Ditto. Comment on attachment 454179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454179&action=review > LayoutTests/http/tests/media/hls/track-in-band-hls-metadata-cue-duration.html:20 > + run('video.src = "http://127.0.0.1:8000/media/resources/hls/metadata/prog_index.m3u8"'); Is it possible to avoid using an absolute url here? Comment on attachment 454179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454179&action=review >> Source/WebCore/ChangeLog:10 >> + the next data cue from the same track starts. This means we donât know the > > Nit. "don't". This is just create-pretty-print failing to deal with unicode. >> LayoutTests/http/tests/media/hls/track-in-band-hls-metadata-cue-duration.html:20 >> + run('video.src = "http://127.0.0.1:8000/media/resources/hls/metadata/prog_index.m3u8"'); > > Is it possible to avoid using an absolute url here? It is possible, but most of the http media tests use absolute urls so it doesn't seem necessary. Committed r291029 (248203@main): <https://commits.webkit.org/248203@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454179 [details]. *** Bug 239067 has been marked as a duplicate of this bug. *** (In reply to Eric Carlson from comment #7) > *** Bug 239067 has been marked as a duplicate of this bug. *** Can you please let me know In which version of Safari this fix will be available? Could you please let me know which version of Safari this fix will be available? |