Bug 237627

Summary: Combine Lookup and Define.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Megan Gardner 2022-03-08 16:09:56 PST 
Combine Lookup and Define.
Comment 1 Megan Gardner 2022-03-08 16:10:49 PST 
Created attachment 454169 [details]
Patch
Comment 2 Megan Gardner 2022-03-08 16:10:54 PST 
<rdar://problem/26205225>
Comment 3 Tim Horton 2022-03-08 16:14:34 PST 
Comment on attachment 454169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454169&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-4243
> -    MCProfileConnection *connection = [PAL::getMCProfileConnectionClass() sharedConnection];
> -    if ([connection effectiveBoolValueForSetting:PAL::get_ManagedConfiguration_MCFeatureDefinitionLookupAllowed()] == MCRestrictedBoolExplicitNo)

Funny that I don't see equivalent code in _lookupForWebView. Still, since this was dead code until a recent change, we should be OK. Maybe Lookup does it internally?
Comment 4 EWS 2022-03-09 23:06:17 PST 
Committed r291091 (248253@main): <https://commits.webkit.org/248253@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454169 [details].