Bug 237617

Summary: Fix Windows debug build
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, fujii.hironori, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230877
https://bugs.webkit.org/show_bug.cgi?id=249797
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Alex Christensen
Reported 2022-03-08 13:03:36 PST
Fix Windows debug build
Attachments
Patch (3.12 KB, patch)
2022-03-08 13:06 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.12 KB, patch)
2022-03-08 13:16 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (3.14 KB, patch)
2022-03-08 13:32 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2022-03-08 13:06:44 PST
Created attachment 454147 [details] Patch
Alex Christensen
Comment 2 2022-03-08 13:16:19 PST
Created attachment 454148 [details] Patch
Alex Christensen
Comment 3 2022-03-08 13:32:35 PST
Created attachment 454150 [details] Patch
EWS
Comment 4 2022-03-08 15:19:53 PST
Committed r291016 (248190@main): <https://commits.webkit.org/248190@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454150 [details].
Radar WebKit Bug Importer
Comment 5 2022-03-08 15:20:29 PST
<rdar://problem/89992900>
Fujii Hironori
Comment 6 2022-03-09 04:20:27 PST
This change broke WinCairo builds. Filed: Bug 237647 – [WinCairo] SpatialNavigation.h(93): error C2365: 'WebCore::None': redefinition; previous definition was 'enumerator'
Fujii Hironori
Comment 7 2022-03-09 05:16:16 PST
*** Bug 230877 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.