Bug 237549

Summary: Compilation error: WebContentProcess.xib: error: macOS xibs do not support target device type "ipad".
Product: WebKit Reporter: Richard Houle <rhoule>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, emw
Priority: P2 Keywords: InRadar
Version: Safari 15   
Hardware: Mac (Intel)   
OS: macOS 12   
Attachments:
Description Flags
Proposed fix v1
ap: review+, ews-feeder: commit-queue-
Fix V1, but with a Changeling. none

Description Richard Houle 2022-03-07 12:56:47 PST
Created attachment 454017 [details]
Proposed fix v1

Xcode for macOS 12.5 complains that we bundle Mac XIBs inside our macCatalyst builds.
Comment 1 Richard Houle 2022-03-07 12:56:57 PST
rdar://89815078
Comment 2 Alexey Proskuryakov 2022-03-07 13:09:33 PST
Comment on attachment 454017 [details]
Proposed fix v1

View in context: https://bugs.webkit.org/attachment.cgi?id=454017&action=review

> Source/WebKit/Configurations/BaseXPCService.xcconfig:40
> +EXCLUDED_SOURCE_FILE_NAMES[sdk=macos*] = $(EXCLUDED_SOURCE_FILE_NAMES_$(CONFIGURATION)) $(EXCLUDED_SOURCE_FILE_NAMES_$(WK_PLATFORM_NAME));

I guess configurations and platform names are disjoint sets, but merging namespaces always gives me shivers.
Comment 3 Alexey Proskuryakov 2022-03-07 13:10:37 PST
rdar://89912760
Comment 4 EWS 2022-03-07 13:57:19 PST
Unable to find any modified ChangeLog in Attachment 454017 [details]
Comment 5 Richard Houle 2022-03-07 14:03:59 PST
Created attachment 454032 [details]
Fix V1, but with a Changeling.
Comment 6 EWS 2022-03-07 15:48:54 PST
Committed r290961 (248143@main): <https://commits.webkit.org/248143@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454032 [details].