| Summary: | File System Access: throw exception if file or directory cannot be accessed in file system | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||
| Component: | Website Storage | Assignee: | Sihui Liu <sihui_liu> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, sihui_liu, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sihui Liu
2022-03-07 09:25:24 PST
Created attachment 454041 [details]
Patch
Comment on attachment 454041 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454041&action=review > Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.cpp:60 > + return nullptr; Should we add release logging if we are not able to create the file handle? Comment on attachment 454041 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454041&action=review I assume this is not testable? > Source/WebKit/ChangeLog:8 > + When a FileSystemHandle is created, we will ensure that correspoding directory or file exists (create the Typo: correspoding Comment on attachment 454041 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454041&action=review >> Source/WebKit/NetworkProcess/storage/FileSystemStorageHandle.cpp:60 >> + return nullptr; > > Should we add release logging if we are not able to create the file handle? The boolean result does not contain error information (and from the error type we can probably infer the errored place), so I would prefer adding error log when we need to debug an error we spot in production builds. (In reply to Chris Dumez from comment #3) > Comment on attachment 454041 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=454041&action=review > > I assume this is not testable? > > > Source/WebKit/ChangeLog:8 > > + When a FileSystemHandle is created, we will ensure that correspoding directory or file exists (create the > > Typo: correspoding ah will change Created attachment 454135 [details]
Patch for landing
Created attachment 454136 [details]
Patch for landing
Committed r291014 (248189@main): <https://commits.webkit.org/248189@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454136 [details]. |