Bug 237522

Summary: ANGLE display cache does not work with explicit device ids
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, geofflang, gman, jonahr, kbr, kkinnunen, kondapallykalyan, kpiddington, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 236487    
Attachments:
Description Flags
Patch none

Kimmo Kinnunen
Reported 2022-03-07 04:17:51 PST
ANGLE display cache does not work with explicit device ids
Attachments
Patch (5.19 KB, patch)
2022-03-07 04:30 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2022-03-07 04:30:55 PST
Created attachment 453964 [details] Patch
EWS Watchlist
Comment 2 2022-03-07 04:32:37 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 3 2022-03-07 12:53:02 PST
Comment on attachment 453964 [details] Patch Looks good to me. r+ The win EWS bot failure is unrelated flakiness. Please upstream this as soon as possible to avoid duplicate work and reduce the chance of conflicts being introduced. Thanks.
Kimmo Kinnunen
Comment 4 2022-03-07 23:37:41 PST
Comment on attachment 453964 [details] Patch thanks!
EWS
Comment 5 2022-03-08 05:43:21 PST
Committed r290987 (248165@main): <https://commits.webkit.org/248165@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453964 [details].
Radar WebKit Bug Importer
Comment 6 2022-03-08 05:44:16 PST
<rdar://problem/89963372>
Note You need to log in before you can comment on or make changes to this bug.