Bug 237493

Summary:

[iOS] Flash media controls when a fullscreen video resets its source

Product:

WebKit

Reporter:

Peng Liu <peng.liu6>

Component:

Media

Assignee:

Peng Liu <peng.liu6>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Fix build failures on watchOS	none
Fix build failures	jer.noble: review+, ews-feeder: commit-queue-
[fast-cq] Patch for landing	none

Description Peng Liu 2022-03-04 20:29:06 PST

Flash media controls when a fullscreen video resets its source

Comment 1 Peng Liu 2022-03-04 20:51:49 PST

Created attachment 453894 [details]
Patch

Comment 2 Peng Liu 2022-03-04 20:52:37 PST

<rdar://79950080>

Comment 3 Peng Liu 2022-03-04 21:20:35 PST

Created attachment 453897 [details]
Fix build failures on watchOS

Comment 4 Peng Liu 2022-03-07 13:24:39 PST

Created attachment 454022 [details]
Fix build failures

Comment 5 Jer Noble 2022-03-07 16:32:14 PST

Comment on attachment 454022 [details]
Fix build failures

View in context: https://bugs.webkit.org/attachment.cgi?id=454022&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:100
> +#if !PLATFORM(WATCHOS)
> +- (void)flashPlaybackControlsWithDuration:(NSTimeInterval)duration;
> +#endif

Nit: let's move this into the AVKitSPI.h header.

Comment 6 Peng Liu 2022-03-07 17:00:16 PST

Created attachment 454053 [details]
[fast-cq] Patch for landing

Comment 7 EWS 2022-03-08 09:30:25 PST

Committed r290997 (248175@main): <https://commits.webkit.org/248175@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454053 [details].