| Summary: | Fix for <select> elements in isolated tree mode. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=237803 | ||||||||
| Attachments: |
|
||||||||
|
Description
Andres Gonzalez
2022-03-04 12:53:50 PST
Created attachment 453867 [details]
Patch
Comment on attachment 453867 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453867&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:3417 > + case AXMenuListValueChanged: This will cause the entire node to be re-computed (tree->updateNode(*notification.first)). Is there more fine-grained set of properties that we can re-compute via tree->updateNodeProperty instead? I doubt people will be changing menu list values often enough for this to be a performance problem, so if we don't want to spend the time investigating this now it's fine. Just curious if you looked into this. (In reply to Tyler Wilcock from comment #3) > Comment on attachment 453867 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453867&action=review > > > Source/WebCore/accessibility/AXObjectCache.cpp:3417 > > + case AXMenuListValueChanged: > > This will cause the entire node to be re-computed > (tree->updateNode(*notification.first)). Is there more fine-grained set of > properties that we can re-compute via tree->updateNodeProperty instead? > > I doubt people will be changing menu list values often enough for this to be > a performance problem, so if we don't want to spend the time investigating > this now it's fine. Just curious if you looked into this. I considered this valid point, and there may be other properties besides the value that we need to update. We may refine if need be in a second pass based on the role and the properties that can be affected. Created attachment 453978 [details]
Patch
Committed r290965 (248145@main): <https://commits.webkit.org/248145@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453978 [details]. |