| Summary: | IDB serialization thread should pass isolated copy of IndexIDToIndexKeyMap to storage thread | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sihui Liu <sihui_liu> | ||||||||
| Component: | WebCore Misc. | Assignee: | Sihui Liu <sihui_liu> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | alecflett, beidson, cdumez, ews-watchlist, jsbell, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sihui Liu
2022-03-03 15:53:40 PST
Created attachment 453792 [details]
Patch
Created attachment 453798 [details]
Patch
Comment on attachment 453798 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453798&action=review r=me with improvement suggestion > Source/WebCore/bindings/js/IDBBindingUtilities.cpp:506 > + indexKeys.add(entry.key, indexKey.isolatedCopy()); I recommend `WTFMove(indexKey).isolatedCopy()`. A lot of types (like String) have special optimizations when isolatedCopy() is called on a r-value expression. (In reply to Chris Dumez from comment #3) > Comment on attachment 453798 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=453798&action=review > > r=me with improvement suggestion > > > Source/WebCore/bindings/js/IDBBindingUtilities.cpp:506 > > + indexKeys.add(entry.key, indexKey.isolatedCopy()); > > I recommend `WTFMove(indexKey).isolatedCopy()`. A lot of types (like String) > have special optimizations when isolatedCopy() is called on a r-value > expression. Sure, will change. Created attachment 453848 [details]
Patch for landing
Committed r290836 (248072@main): <https://commits.webkit.org/248072@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453848 [details]. |