| Summary: | Simplify pseudo element resolution | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||
| Component: | CSS | Assignee: | Antti Koivisto <koivisto> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, glenn, graouts, kondapallykalyan, pdr, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 237362 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Antti Koivisto
2022-03-03 02:26:50 PST
Created attachment 453713 [details]
Patch
Created attachment 453719 [details]
Patch
Created attachment 453724 [details]
Patch
Created attachment 453725 [details]
Patch
Comment on attachment 453725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453725&action=review > Source/WebCore/ChangeLog:64 > + You probably want to merge the two ChangeLog entries. > Source/WebCore/rendering/style/RenderStyle.cpp:116 > + auto newStyle = RenderStyle(style, Clone); I have a question reading this code: do we prefer this to the more compact `RenderStyle newStyle(style, Clone)`? ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Created attachment 453743 [details]
Patch for landing
> > + auto newStyle = RenderStyle(style, Clone);
>
> I have a question reading this code: do we prefer this to the more compact
> `RenderStyle newStyle(style, Clone)`?
I don't think there is policy on this but I feel it often reads better like this.
Committed r290779 (248023@main): <https://commits.webkit.org/248023@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 453743 [details]. |