| Summary: | [Style] Forbid spaces between type names and protocol names in Objective-C | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, ews-watchlist, glenn, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Myles C. Maxfield
2022-03-02 20:34:19 PST
Created attachment 453694 [details]
Patch
Comment on attachment 453694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453694&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:3420 > + using_space_with_protocol = search(r'\Wid <', line) Is \W better than \b for this? Comment on attachment 453694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=453694&action=review >> Tools/Scripts/webkitpy/style/checkers/cpp.py:3420 >> + using_space_with_protocol = search(r'\Wid <', line) > > Is \W better than \b for this? \b is probably better. I’ll update before landing. Committed r290784 (248028@trunk): <https://commits.webkit.org/248028@trunk> |