Bug 237400

Summary: Rename RenderStyle::textDecoration() to RenderStyle::textDecorationLine()
Product: WebKit Reporter: Oriol Brufau <obrufau>
Component: CSSAssignee: Oriol Brufau <obrufau>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, changseok, darin, dino, dmazzoni, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, jcraig, jdiggs, joepeck, koivisto, kondapallykalyan, macpherson, menard, mmaxfield, pdr, sabouhallawa, samuel_white, schenney, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 237175    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Oriol Brufau
Reported 2022-03-02 16:41:17 PST
Before https://webkit.org/b/237175, the text-decoration-line and text-decoration properties were 2 longhands that shared a computed value, accessed via RenderStyle::textDecoration(). But now text-decoration is a proper shorthand, and it expands to text-decoration-line, text-decoration-color, etc. So it doesn't make much sense to continue accessing the line via textDecoration(), it should be textDecorationLine() instead. Same for RenderStyle::setTextDecoration(), etc.
Attachments
Patch (26.27 KB, patch)
2022-03-02 16:52 PST, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
Patch (26.33 KB, patch)
2022-03-14 16:17 PDT, Oriol Brufau 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oriol Brufau
Comment 1 2022-03-02 16:52:42 PST
Created attachment 453679 [details] Patch
Radar WebKit Bug Importer
Comment 2 2022-03-09 16:42:15 PST
<rdar://problem/90065611>
EWS
Comment 3 2022-03-14 16:11:59 PDT
Tools/Scripts/svn-apply failed to apply attachment 453679 [details] to trunk. Please resolve the conflicts and upload a new patch.
Oriol Brufau
Comment 4 2022-03-14 16:17:38 PDT
Created attachment 454633 [details] Patch
EWS
Comment 5 2022-03-14 17:43:10 PDT
Committed r291257 (248409@main): <https://commits.webkit.org/248409@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454633 [details].
Note You need to log in before you can comment on or make changes to this bug.